Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(invoice-preview): add preview support for wallet and credit note credits #3084

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

lovrocolic
Copy link
Collaborator

Context

Preview feature enables fetching first Lago invoice. This invoice is not persisted and is calculated on the fly.

Description

This PR adds logic for applying wallet and credit note credits on preview invoice.

Copy link
Contributor

@floganz floganz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I've some ideas how we can simplify the code if you agree with them.

app/services/invoices/preview_service.rb Outdated Show resolved Hide resolved
app/services/invoices/preview_service.rb Outdated Show resolved Hide resolved
app/services/invoices/preview_service.rb Outdated Show resolved Hide resolved
app/services/invoices/preview_service.rb Outdated Show resolved Hide resolved
@lovrocolic lovrocolic merged commit 60ddac5 into main Jan 23, 2025
6 checks passed
@lovrocolic lovrocolic deleted the add-preview-credits branch January 23, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants