Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: Add external_customer_id on wallet serializer #427

Merged
merged 1 commit into from
Sep 1, 2022
Merged

misc: Add external_customer_id on wallet serializer #427

merged 1 commit into from
Sep 1, 2022

Conversation

rsempe
Copy link
Collaborator

@rsempe rsempe commented Sep 1, 2022

Context

We want to clarify the difference between lago ids and external ids.

Description

The goal of this PR is to:

  • return external_customer_id on wallet serializer

lovrocolic
lovrocolic approved these changes Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@lovrocolic lovrocolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@rsempe rsempe merged commit 4178b0d into main Sep 1, 2022
@rsempe rsempe deleted the external-id-serializer branch September 1, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-pochet vincent-pochet vincent-pochet approved these changes

@lovrocolic lovrocolic lovrocolic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsempe @vincent-pochet @lovrocolic