misc: resolve ws security issue #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have. security issue with WS
It relied on 3 packages: 1 bundle analyzer and 2 about graphql.
I opened a discussion on the bundle analyzer one but waiting for the resolution, I prefer to remove the package for now.
For the two graph related, they were at >v8 already and the remaining minor were simple patches and nothing breaking.
It's kinda safe to fix them to an upper version waiting for them to migrate to the last patched ws version.
I ran the codegen tho to make sure we have the last version with this patch