chore: fix ws deep package version #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansmonjol
added
🥷 chore
keellyp
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have multiple packages relying internally on
wsdependency. mostly all are on8.xversions of it.Also
wshave a CVE fix available starting on those versions.5.2.4,6.2.3,7.5.10,8.17.1wshas recently manually fixed to a upper version in our repo: https://github.com/getlago/lago-front/pull/1685/filesI did that as a quick fix, and also removed
webpack-bundle-analyseras it was the only one to rely on a7.xversion ofwsDescription
This PR does reintroduce
webpack-bundle-analyserpackage, and I updated concerned packages so they can use the new^8.xor^7.x versioncontaining the fix. Note that internally they use^notation forws, so they had the fix but the deep pckage version were not updated in our project yet.Update deep version with yarn today is mainly about removing a package and installing it again: yarnpkg/yarn#2394 (comment)
Also, as those version concerns the codegen, I ran it again hence having some changes on the generated file.
Here is the new
wsversion status on our app after those changes.