Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manage api keys permission in form #1893

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

ansmonjol
Copy link
Collaborator

@ansmonjol ansmonjol commented Nov 29, 2024

Context

We're improving the way users can manage API Keys in their application

Description

This PR is the last step of the feature and allows to edit the permissions the API key can manage.

Noticeable change:

  • I had to transform the api keys JSON format received from BE to manage them in the form, before re-transforming them for BE save.
  • There is an extra commit to update the spacing between label and checkbox/radio. Asked by design team I made it part of this PR

Fixes LAGO-584

@ansmonjol ansmonjol added the 🛠 feature New feature or request label Nov 29, 2024
@ansmonjol ansmonjol self-assigned this Nov 29, 2024
@ansmonjol ansmonjol force-pushed the api-keys-permissions branch from b134ea5 to de072d7 Compare November 29, 2024 16:11
@ansmonjol ansmonjol force-pushed the api-keys-permissions branch from de072d7 to 192bdd3 Compare December 4, 2024 14:52
@ansmonjol ansmonjol force-pushed the api-keys-permissions branch from 68b9e61 to 7b599aa Compare December 4, 2024 16:58
@ansmonjol ansmonjol marked this pull request as ready for review December 5, 2024 07:52
@ansmonjol ansmonjol merged commit 202aab1 into main Dec 5, 2024
8 checks passed
@ansmonjol ansmonjol deleted the api-keys-permissions branch December 5, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants