Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: make sure we control filter values displayed #1897

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

ansmonjol
Copy link
Collaborator

Context

We display some invoice status filter values that are internal states for Lago, hence not being relevant for customers

Description

This PR make sure we only display what we want to, also passes on other filters to use proper translations for the filter's label

Fixes ISSUE-572

@ansmonjol ansmonjol added the 🐞 bug Something isn't working label Dec 2, 2024
@ansmonjol ansmonjol self-assigned this Dec 2, 2024
Copy link
Collaborator

@stephenlago99 stephenlago99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just a thought I had while going through the changes, not sure if it would be worth it to extract the values in separate objects (like we do for translations). Maybe not in this case, since the enum values aren't reused.

@ansmonjol
Copy link
Collaborator Author

Looks good!

Just a thought I had while going through the changes, not sure if it would be worth it to extract the values in separate objects (like we do for translations). Maybe not in this case, since the enum values aren't reused.

We could indeed, most of them are a re-usage of existing ones but sometimes they are uses in title and not only in "usage values" so might be overkill here.
Always possible later!

@ansmonjol ansmonjol enabled auto-merge (squash) December 2, 2024 10:54
@ansmonjol ansmonjol merged commit 0f87615 into main Dec 2, 2024
12 checks passed
@ansmonjol ansmonjol deleted the fix-filters-values branch December 2, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants