bug(Combobox): fix element height with description #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenlago99
approved these changes
Jan 8, 2025
Yeah it appear they changed their API on v6 also removed some very custom ways to implement and are more into overriding their style. Which is pretty handy as we want to benefit some of their internal logic such as item height calculation 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the Combobox element height if it contains a description.
Note: I'm tired of those shenanigans and random calculation values there and in the multiple combobox. I think we should (i) upgrade MUI to v6, (ii) negociate to have a combobox looking like the MUI doc with design, (iii) remove all our custom implementation to get something simpler that works without all this magic and the world would be much safer place.
Fixes ISSUE-619