misc: Bump version from 1.12.3 to 1.12.4 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Make sure that your PR is not a duplicate.
If not, then make sure that:
a. You have done your changes in a separate branch. Branches MUST have descriptive names that start with either the
fix/orfeature/prefixes. Good examples are:fix/signin-issueorfeature/issue-templates.b. You have a descriptive commit message with a short title (first line).
c. You have only one commit (if not, squash them into one commit).
d.
npm testdoesn't throw any error. If it does, fix them first and amend your commit (git commit --amend).After these steps, you're ready to open a pull request.
a. Give a descriptive title to your PR.
b. Describe your changes.
c. Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).d. Add the corresponding labels to your pull request (ex: feature, improvement, bug...)
IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.
PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING