Remove allOf to reference EventInput in /event endpoint
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienbourdeau
changed the title
allOf to referecen EventInput in /event endpointallOf to reference EventInput in /event endpoint
ivannovosad
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #249 I'm removing the
allOfto refer to the EventInputObject schema in EventInput.Today, the batch
EventBatchInputhas the complete definition of an event, while theEventInputreferences#/components/schemas/EventBatchInput/properties/events/items.This PR changes so
EventInputhas the definition of an event andEventBatchInputreferences it."What's the difference" you're asking. I dunno but I'm hoping it's going to make a difference for openapi-generator when generating client. Also, it feels a little better.
Note: make sure you expend the diff of
openapi.yaml