Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Remove *_count fields #305

Merged
merged 1 commit into from
Dec 11, 2024
Merged

misc: Remove *_count fields #305

merged 1 commit into from
Dec 11, 2024

Conversation

vincent-pochet
Copy link
Contributor

@vincent-pochet vincent-pochet commented Nov 28, 2024

Context

The API response are returning a lot of counters. Since the exposed resources can be linked to a lot of objects and can be called a lot, these counters are posing a scalability problem and are slowing down the global performance of the API.

To remediate the situation the decision was made to remove all these fields.

Changes

This PR removes the following fields:

  • BillableMetricObject
    • active_subscriptions_count
    • draft_invoices_count
    • plans_count
  • PlanObject
    • active_subscriptions_count
    • draft_invoices_count
  • TaxObject
    • add_ons_count
    • charges_count
    • customers_count
    • plans_count

@rsempe rsempe merged commit 2966766 into main Dec 11, 2024
3 checks passed
@rsempe rsempe deleted the misc-remove-filters branch December 11, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants