Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change codegen api path #454

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: change codegen api path #454

merged 1 commit into from
Jan 23, 2025

Conversation

brunomiguelpinto
Copy link
Contributor

@brunomiguelpinto brunomiguelpinto commented Jan 22, 2025

Context

This PR updates the CODEGEN_API environment variable in the docker-compose.dev.yml file to resolve an issue preventing the frontend Docker container from running yarn codegen.

Previously, the CODEGEN_API was set to https://api.lago.dev/graphql, which was inaccessible within the Docker environment. The new value, http://api:3000/graphql, points to the appropriate internal service and allows yarn codegen to execute successfully.

@brunomiguelpinto brunomiguelpinto self-assigned this Jan 22, 2025
Copy link
Contributor

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Could you just add a (short) description in the pull request, for the future us looking for changes :D

@brunomiguelpinto brunomiguelpinto merged commit dfb7b73 into main Jan 23, 2025
@brunomiguelpinto brunomiguelpinto deleted the fix-docker-codegen branch January 23, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants