feat(docker): Use .env files for dev environment #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday, I had troubles with webhooks because I wasn't running the
api-webhook-workerservice whileSIDEKIQ_WEBHOOKwas forced to true for all services. See #439I wanted to make make it easy to turn on and off this feature. I don't want to be running 5 separate workers at all time in dev.
One approach was to use
SIDEKIQ_WEBHOOK=${SIDEKIQ_WEBHOOK:-true}but inspired by #452 I thought we could do better.This PR introduces
.envfiles for docker dev env..env.development.defaultholds all the default values..env.developementis not committed, it's yours. Override any value you want. It's also optional.The default file is very important because otherwise we can't easily add new env vars. If we had a .env.example that people copy once, they would never get the new value
I'm open to suggestion for the .env file names since there is no standard.