Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LoggingHandler time conversion #304

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

YoavCohen
Copy link

Current version covert it to wrong time(offset of local time was added to epoch).
In additon ms are now included.

Current version covert it to wrong time(offset of local time was added to epoch).
In additon ms are now included.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 73.642% when pulling 765f80f on YoavCohen:fix_LoggingHandler_time_conversion into 3e0badb on getlogbook:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 73.642% when pulling 765f80f on YoavCohen:fix_LoggingHandler_time_conversion into 3e0badb on getlogbook:develop.

@coveralls
Copy link

coveralls commented Nov 21, 2019

Coverage Status

Coverage decreased (-0.3%) to 74.08% when pulling 765f80f on YoavCohen:fix_LoggingHandler_time_conversion into 3e0badb on getlogbook:develop.

@RazerM
Copy link
Collaborator

RazerM commented Jul 2, 2023

I think this might not be correct, it would be better if you could demonstrate what the issue is as a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants