-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Enable support for avif #192
Comments
Can't avif be stored in a cbz? |
Anything can be stored in a cbz format since its a zip file, but Mango has a hardcoded SUPPORTED_IMG_TYPES which specifies image formats Mango will recognize, and avif isn't in there. |
Yes you are right. I guess there's no harm in supporting more image formats 👍 |
So, do we allow files whose mime type is |
@Leeingnyo Yes I think we can do that. One potential issue is that, if the first page of an entry has a type not supported by image_size.cr, Mango would fail to generate the thumbnail. But this won't break anything and Mango would just serve the original file instead. |
Support additional image formats (resolves #192)
Hi there! The feature has been added in v0.24.0. Thanks for the feature request! |
Is your feature request related to a problem? Please describe.
As more browsers are getting native support for avif, it would be nice to also have mango support this format.
It's supported by Firefox, Chrome, and Opera.
It's not supported by Safari and Edge.
Describe the solution you'd like
Add image/avif to the list of supported image formats
Describe a small use-case for this feature request
If you are working with higher quality images, the size reduction from jpeg can be dramatic, so it would be beneficial for bandwidth and disk space savings.
Additional context
I also don't see why image/gif isn't supported, this is an ancient format supported by practically all browsers.
https://caniuse.com/avif
The text was updated successfully, but these errors were encountered: