Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting SQS: Support JSON format to moto-3.1.18 #7036

Closed
wants to merge 1 commit into from

Conversation

ziyanli-amazon
Copy link

@ziyanli-amazon ziyanli-amazon commented Nov 17, 2023

This is the exact same commit that fixes Issue
This commit is based off tag 3.1.18
Just back-porting this PR to version 3.1.18

@bblommers
Copy link
Collaborator

Hi @ziyanli-amazon! We don't support Moto 3.x anymore - we only develop for the current version.

Are you running into any issues upgrading to 4.x?

@ziyanli-amazon
Copy link
Author

@bblommers Hi, the reason for this PR is that we still have some internal customers who depend on 3.x. No, there's no issue for 4.x.
Is there any other way we can patch the 3.x version ?

@bblommers
Copy link
Collaborator

Hi @ziyanli-amazon, I've just released 3.1.19. It contains this change, plus a few others that were necessary to get our internal tests to pass.

https://pypi.org/manage/project/moto/release/3.1.19/

Just to make sure this doesn't generate any expections:
My earlier statement still stands - We don't support Moto 3.x anymore - we only develop for the current version..

The decision to release this version was more curiosity then anything else, to see how much effort it would take.

Like I said, (almost) all of our internal tests pass against this version, but let me know if you run into any issues.

This is the PR with all the changes: #7042

@bblommers bblommers closed this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating of SQS queues with latest botorecore (1.29.127) is broken
2 participants