Techdebt: Remove old/deprecated code #7220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblommers
force-pushed
the
techdebt/remove-old-code
branch
from
3c3ef8b
to
542ccbd
Compare
bblommers
added a commit
that referenced
this pull request
Jan 27, 2024
bblommers
added a commit
that referenced
this pull request
Jan 27, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove warning when describing an unknown EC2 image. The warning has been there for ages, and I've never heard of someone needing this validation, so I'm just removing it for now. If necessary, we can make the exception opt-in (allow it by default, but throw the correct exception of the user explicitly configures it) (The warning was introduced in #1331, for context.)
Remove
moto_server serviceargument - we can just runmoto_serverfor all services, no need to run a separate server per service anymoreRemove warnings from KMS/Events - info about what params are implemented should just be part of the documentation
Rename EC2
add_instancestorun_instancesto make it more obvious which action we're talking aboutRemoves imports from
moto.core, as they shouldn't necessarily be exposed to end-users