-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS Static Libs #15
Comments
Not atm, but @Deams51 is working on a linux compile; with both systems based on unix a port to mac should then be reasonable. That said, the https://github.com/getnamo/socketio-client-prebuild static libraries just need to be recompiled for mac osx and included in the build.cs, then the rest should just work in theory. If you can get those compiled for osx, make a pull request! See: #19 for more guidance, another dev is trying to set everything up for IOS. |
I get macos run successfully |
Great work! Make a pull request for the build script on: https://github.com/getnamo/socketio-client-prebuild and add the .a's directly on this repository (inside https://github.com/getnamo/socketio-client-ue4/tree/master/ThirdParty/SocketIO/Lib and https://github.com/getnamo/socketio-client-ue4/tree/master/ThirdParty/Boost/Lib) as a pull request. I'll merge them in and the plugin will have your updates going forward :) |
cause my submodule clone through https is not very smooth, I use 1.60.0 zip source, |
merged the macos into master, can you build the latest version of the plugin and let me know if it all works as usual? |
merged a pull request (#61) from @skatpgusskat with updated prebuilt libraries for macos. I couldn't personally verify, but if any mac user can sync to latest master and test it out, It would be great to get a second confirmation everything works! |
unfortunately this does not appear to be the fix :( output below
|
I've started to look at the Prebuild project but so far have some CMake errors etc. will get back to it soon |
I'm not 100% certain this is the issue but Otherwise it seems to spit out a similar error to the linux build (see this comment: #70 (comment)) |
Yup I tried all of the options in #70 and no help, also I am building on 10.13. I set the build targets all to 10.12 just in case, but that did not make any difference. My research on that is that it is a warning and the error, the error seems to be specifically "Undefined symbols for architecture x86_64" Even though I grabbed the newer libsioclient.a I am thinking we may need to also rebuild the boost .a's for x64. Hence my trying to get the Prebuild stuff working - I'll see if I can get some time on it tomorrow. |
OK I did a rebuild and now Its working. I did also have to install boost but looking OK I think. If you like I can do a PR for the libs |
Awesome, if you have a working libs for both boost and sioclient such that it works in a fresh project without additional dependencies by all means open a pr and I'll merge it. |
Here you. go. #75 and I am just using the sioclient from before. |
Couldn't personally verify but merged the PR here: e7427e6. It would be great to have another mac user confirm that version latest master/ v0.7.4 works without additional dependencies. |
@anadin I'm trying to run the latest master on macos, but I get the same error message you had before (I'm also running macos 10.13). You mentioned you did a rebuild and got it to work, could you specify what you rebuilt to get it working? I'll try to do the same to see if I get the same result :) |
Not sure if anybody is still interested, but I just got everything working on a Mac running MacOS Mojave (10.14). Basic steps:
Not sure if my libs would work for anything below MacOS Mojave though ... but if someone cares to try it out ... |
Oh and now for something completely different .... iOS and Android. Basic use case is for VR/AR applications working together. |
If it's working, feel free to make a pull request with the working libs and I'll merge them, then we could have some other mac users test it out and confirm. |
I'ld love to do this, but I'm not sure how to ... I'm not exactly fluent in all things Git. I know this: #15 (comment) refers to it, but that's about all I know. If you can give me some further hints I will see to it. |
To make a pull request you fork this repository(consider using the desktop client to simplify things https://desktop.github.com/), change the files/src with your fixes in your fork and then commit them. Once that's done you make a pull request from your fork (can be done here: https://github.com/getnamo/socketio-client-ue4/pulls). See also https://help.github.com/articles/creating-a-pull-request/ for help Don't worry about making a wrong pull request I'll guide you to fix it once I see it |
Ok. I have just created a pull request: #107 |
That was a clean pull request 👍, merged a47e89c. Pinging any other mac user to re-pull the master repo and try out the new static libs by @iambeeblebrox. Let me know if mac osx now works for you too! |
@iambeeblebrox switched to including the source directly a separate module. This removes the need for platform specific static libs, could you try pulling the latest master and see if it compiles without issue on MacOS? |
@getnamo sorry it took a while. I was away on an extended holiday ;-). I will test the latest version a.s.a.p. |
@getnamo Green Light!!! I have just compiled a test project with the 1.0 version on my Mac. Works like a charm. This is not an exhaustive test mind you but it compiles and runs without issues anyway. By the way: is there a reason why you limit the 1.0 release to UE 4.22? I tested it with 4.21 (updated the uplugin file) and that seemed to work fine. If I find the time I will give iOS a go tomorrow. |
That's great news, thanks for checking! Regarding 1.0, it's simply because I don't backport releases to keep my sanity, but there will be many versions that will work on earlier engine versions without issue if recompiled. |
Closing as it's working. If an issue with MacOS crops up, open a new issue. |
Is there a macos version
The text was updated successfully, but these errors were encountered: