Vlad/update customer invoices #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…merInvoicesByName method. This getCustomerInvoicesByName method accepts pagination and filter params
vladpoltorin
commented
Dec 7, 2023
| /** | ||
| * @deprecated Use `getCustomerInvoicesByName()` to fetch customer's invoices. | ||
| * This method doesn't accept parameters to filter invoices and will be removed in the next major version. | ||
| */ |
There was a problem hiding this comment.
decided to deprecate this one, bc someone might use it
vladpoltorin
commented
Dec 7, 2023
src/resources/customers.ts
Outdated
| /** | ||
| * Get Customer's invoices. | ||
| */ | ||
| public getCustomerInvoicesByName( |
There was a problem hiding this comment.
I'll probs rename this one
There was a problem hiding this comment.
Could we extend the other one to take optional filter args for the other inputs?
If not, can we just call this getInvoices
There was a problem hiding this comment.
@akshalaby it's better to leave an old method as deprecated, so I just renamed the method name
akshalaby
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getCustomerInvoicesmethod and introducedgetCustomerInvoicesByName, which accepts all params for filtering and pagination