OData subtable: $top=0 returns all records

[matthew-white]

When I specify $top=0 for the Submissions table, it returns an empty array. However, when I specify $top=0 for a subtable, it seems to return all records.

As background, I was specifying $top=0 together with $count=true in order to determine the number of records in a repeat group, related to this forum post. I ended up specifying $top=1 in order not to pull all records. (By the way, I would also be interested if there is a better way to determine that count!)

I think this logic can be found in the extractPaging() function below, where if limit is 0, it defaults to Infinity:

central-backend/lib/formats/odata.js

Lines 53 to 62 in dab8530

	const extractPaging = (table, query) => {
	const limit = parseInt(query.$top, 10) || Infinity;
	const offset = parseInt(query.$skip, 10) || 0;
	const shouldCount = isTrue(query.$count);
	const result = { limit: max(0, limit), offset: max(0, offset), shouldCount };
	return Object.assign(result, (table === 'Submissions')
	? { doLimit: Infinity, doOffset: 0 }
	: { doLimit: result.limit, doOffset: result.offset });
	};

[issa-tseng]

looks like odata doesn't have any independent count-only endpoint so we'd have to make one if we wanted one

[matthew-white]

That's interesting that OData doesn't have an independent count-only endpoint. What do you think about using the combination of $count=true + $top=0 to fetch just the count?

[issa-tseng]

yeah i'll fix this top thing rn