Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log error when Google Drive backups are not configured #346

Closed
lognaturel opened this issue Mar 25, 2021 · 7 comments
Closed

Don't log error when Google Drive backups are not configured #346

lognaturel opened this issue Mar 25, 2021 · 7 comments

Comments

@lognaturel
Copy link
Member

When backups are not configured, they still make an attempt to run every 24 hours. This results in the error message {"0":"n","1":"o","2":" ","3":"b","4":"a","5":"c","6":"k","7":"u","8":"p","9":" ","10":"c","11":"o","12":"n","13":"f","14":"i","15":"g","16":"u","17":"r","18":"e","19":"d","success":true} every day in the backup log. e.g. https://sandbox.getodk.cloud/#/system/backups

If backups are not configured, there's already a big notice at the top of the backups page. There should not be a daily log message.

@issa-tseng
Copy link
Member

i guess the reason i log at all is bc i don't fully trust how i'm running cron and i'd like to know that the script is running at all. is it a big deal it logs?

@lognaturel
Copy link
Member Author

It's scary and confusing to users, especially in its current incarnation. Maybe frontend could only display the log section if backups are configured?

@issa-tseng
Copy link
Member

obv i'll fix the message (did already actually)

@issa-tseng
Copy link
Member

oh okay i'm good w that. also if the message is fixed it's probably not so bad

@lognaturel
Copy link
Member Author

Great! So I think this can be closed, then, and we can evaluate what the new message looks like and see whether we want to do the frontend issue. It's true it might feel less like something terrible has happened with a message that looks more intentional.

@issa-tseng
Copy link
Member

it says (lol)

{ "did": "nothing", "because": "no backup configured"}

@lognaturel
Copy link
Member Author

😅

issa-tseng added a commit that referenced this issue Mar 26, 2021
* resolves #346 as far as we've decided to do for now.
issa-tseng added a commit that referenced this issue Mar 26, 2021
* resolves #346 as far as we've decided to do for now.
@lognaturel lognaturel reopened this Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants