Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When there is a published form version, don't update form name from new drafts #355

Closed
lognaturel opened this issue Apr 7, 2021 · 0 comments
Closed

When there is a published form version, don't update form name from new drafts #355

lognaturel opened this issue Apr 7, 2021 · 0 comments

Comments

@lognaturel
Copy link
Member

#344 updates the form name based on new form definitions. It does this update every time a new draft is created. This becomes confusing if the title change is anything other than a typo fix and especially confusing if a draft with a title change is created and then abandoned.

The expected behavior is that the title of the most recent draft is used until there's a published version at which point the title of the most recent published version is always used whether or not there's an active draft.
ktuite added a commit that referenced this issue Apr 16, 2021
@ktuite
Another potential fix to issue #355 that adds title to FormDef
ce5a72c
@ktuite ktuite mentioned this issue Apr 16, 2021
Closed
ktuite added a commit that referenced this issue Apr 22, 2021
@ktuite
Potential fix to #355, update form tites by re-parsing xml on publish
e0986db
ktuite added a commit that referenced this issue Apr 22, 2021
@ktuite
Another potential fix to issue #355 that adds title to FormDef
5c898cd
ktuite added a commit that referenced this issue Apr 23, 2021
@ktuite
Fixes issue #355: adds FormDef.name and removes Form.name
fd5203d 
Potential fix to #355, update form tites by re-parsing xml on publish

Another potential fix to issue #355 that adds title to FormDef

Minor fixes

More concise and functional code style

Migration that backfills form def names from xml titles

Added form name check to form list api test

Experimentally trying to remove Form.name and use FormDef.name instead

Run all 4 of ktuite's recent form title updating tests

Debug tap of version in versionJoinCondition

Using coalesce to join form with whatever formdef is appropriate

Fixes issue #355: adds FormDef.name and removes Form.name
@ktuite ktuite mentioned this issue Apr 23, 2021
Closed
ktuite added a commit that referenced this issue Apr 27, 2021
@ktuite
Fixes issue #355: adds FormDef.name and removes Form.name
e1a1344 
Potential fix to #355, update form tites by re-parsing xml on publish

Another potential fix to issue #355 that adds title to FormDef

Minor fixes

More concise and functional code style

Migration that backfills form def names from xml titles

Added form name check to form list api test

Experimentally trying to remove Form.name and use FormDef.name instead

Run all 4 of ktuite's recent form title updating tests

Debug tap of version in versionJoinCondition

Using coalesce to join form with whatever formdef is appropriate

Fixes issue #355: adds FormDef.name and removes Form.name
issa-tseng pushed a commit that referenced this issue Apr 27, 2021
@ktuite @issa-tseng
improve #355: store and return name on def rather than logical form.
3371512 
* as a side effect this commit causes unpublished forms to return draft
  details rather than null values. use publishedAt to determine
  draftiness.
* see PR notes #359.
* resolves #355.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update form name by storing name on FormDef instead of Form getodk/central-backend
1 participant
@lognaturel