oidc: use mustache for templating #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
approved these changes
Oct 3, 2023
lib/resources/oidc.js
Outdated
| @@ -118,47 +162,7 @@ module.exports = (service, endpoint) => { | |||
| // Instead, we need to render a page and then "browse" from that page to the normal frontend: | |||
|
|
|||
| // id=cl only set for playwright. Why can't it locate this anchor in any other way? | |||
There was a problem hiding this comment.
Maybe move this comment closer to loaderTemplate above?
| </div> | ||
| </body> | ||
| </html> | ||
| `; | ||
| parse(template); // caches template for future perf. | ||
|
|
||
| const frontendPage = ({ head='', body }) => render(template, { head, body }); |
alxndrsn
force-pushed
the
oidc-moustache
branch
from
1ac8cf7 to
c8711a5
Compare
This was referenced Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach to #1008 & #1011.