Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resources/odata: don't crash with surprising instanceId #1158

Merged
merged 16 commits into from
Oct 15, 2024
Merged

resources/odata: don't crash with surprising instanceId #1158

merged 16 commits into from
Oct 15, 2024

Conversation

alxndrsn
Copy link
Contributor

Closes #1157

@alxndrsn
Copy link
Contributor Author

alxndrsn commented Jun 19, 2024 •
edited
Loading

There may be a more general problem of potential unhandled errors in sync code within promise chains. A more general way of detecting & fixing or avoiding these issues could be helpul.

Most of the e2e test changes may be brought in by #1071.

@lognaturel lognaturel mentioned this pull request Jun 19, 2024
Closed
@lognaturel lognaturel removed their request for review October 7, 2024 17:14
sadiqkhoja
sadiqkhoja approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@sadiqkhoja sadiqkhoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor improvements, otherwise this solves the original problem.

lib/resources/odata.js Outdated Show resolved Hide resolved
test/e2e/standard/test.js Outdated Show resolved Hide resolved
test/e2e/standard/run-tests.sh Show resolved Hide resolved
@alxndrsn alxndrsn merged commit c37846d into getodk:master Oct 15, 2024
1 check passed
@alxndrsn alxndrsn deleted the odata-backend-crash-handling branch October 15, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadiqkhoja sadiqkhoja sadiqkhoja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backend crash when opening hostile-named submission detail
2 participants
@alxndrsn @sadiqkhoja