improve: worker resiliency, hopefully. #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
issa-tseng
commented
Dec 2, 2021
issa-tseng
commented
- one try/catch we didn't have before, around checker invocation.
- one .catch() we didn't have before, around checker promise result.
- watchdog timer which kicks the loop if it looks stale.
* one try/catch we didn't have before, around checker invocation. * one .catch() we didn't have before, around checker promise result. * watchdog timer which kicks the loop if it looks stale.
|
resolves #388 hopefully. |
ktuite
approved these changes
Dec 16, 2021
|
Restored because I need to try this branch on a production server. |
|
@yanokwa i just pushed an update to the branch now, adding some additional sentry logging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.