Make Authorization header checks tighter #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxndrsn
force-pushed
the
more-explicit-auth-header-checks
branch
from
9ba6ca2 to
c024af1
Compare
sadiqkhoja
reviewed
Apr 28, 2023
sadiqkhoja
approved these changes
Apr 28, 2023
|
It looks like the branch has a conflict. @alxndrsn, are you able to merge this PR sometime this week? We're hoping to begin QA for .3 next week. |
added 2 commits
May 9, 2023 04:28
Include trailing space in checks for Basic and Bearer prefixes in Authorization headers. This space is already assumed to exist in subsequent parsing code. An extra check is added for requests which _provide_ the Authorization header, but in an unrecognised format. This ensures that a 401 header is still sent in preference to 404, as per getodk#329.
alxndrsn
force-pushed
the
more-explicit-auth-header-checks
branch
from
18cba8f to
cf8a291
Compare
added 7 commits
May 9, 2023 04:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include trailing space in checks for
BasicandBearerprefixes in Authorization headers. This space is already assumed to exist in subsequent parsing code.An extra check is added for requests which provide the Authorization header, but in an unrecognised format. This ensures that a 401 header is still sent in preference to 404, as per #329. It also changes the response code for unsupported auth-schemes when they do not start with either
BearerorBasic.