Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case where user is logged into one tab and attempts to log in to another #362

Closed
lognaturel opened this issue Aug 13, 2020 · 0 comments · Fixed by #415
Closed

Handle case where user is logged into one tab and attempts to log in to another #362

lognaturel opened this issue Aug 13, 2020 · 0 comments · Fixed by #415
Labels
needs discussion Discussion needed before work can begin

Comments

@lognaturel
Copy link
Member

Currently a user sees Incorrect email address and/or password. even if their credentials are correct. This is because the request includes the session cookie but not the CSRF token.

@matthew-white has suggested sending a second request to /sessions/restore and in case of a different user attempting to log in, display a message like “You are already logged in as X. Please refresh the page to continue.”

@lognaturel lognaturel added the needs discussion Discussion needed before work can begin label Aug 13, 2020
matthew-white added a commit that referenced this issue Feb 9, 2021
Closes #122. Closes #362.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Discussion needed before work can begin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant