Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to list messages that may be duplicates #1085

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthew-white
Copy link
Member

I've wanted to search the codebase for duplicate i18n messages for a while, but it felt slightly complicated. I was randomly thinking about it and realized that it wouldn't be that hard. This PR adds a script along those lines, listing i18n messages that look like duplicates.

What has been done to verify that this works as intended?

When I ran the script, it flagged a number of false positives. However, it also successfully identified several duplicate messages: getodk/central#828.

Why is this the best possible solution? Were any other approaches considered?

The script doesn't list duplicates that it considers to be likely false positives. Maybe it'd be nice at some point to add a flag to list all duplicates that the script sees.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@matthew-white matthew-white requested a review from ktuite December 8, 2024 18:22
@matthew-white
Copy link
Member Author

@ktuite, I've tagged you for review, but I think we can wait to review this until after the release goes out.

@matthew-white

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant