Feature #741: Use opaque cursor on submission list and entity list #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This is a great simplification! I love that we no longer need to track instance IDs or have challenges related to scrolling in chunks while there's concurrent creation or deletion. The code here definitely looks like it's on the right track. I've left some suggestions, but I think @ktuite could do the final review without me if that ends up working best. Excited for $skiptoken and the changes here!
This was referenced Sep 2, 2023
sadiqkhoja
commented
Sep 5, 2023
sadiqkhoja
commented
Sep 7, 2023
| if (props.totalCount <= props.top) | ||
| return tcn(`${props.type}.all`, props.totalCount); | ||
|
|
||
| // console.log( t('submission.first', { count: 'asdf', top: 10 }, 11 ) ); |
src/util/i18n.js
Outdated
| @@ -43,3 +43,8 @@ export const loadLocale = ({ i18n, logger }, locale) => { | |||
| export function $tcn(path, count, values = undefined) { | |||
| return this.$tc(path, count, { count: this.$n(count, 'default'), ...values }); | |||
| } | |||
|
|
|||
| // same as above but for composition API | |||
| export function tcn(path, count, values) { | |||
There was a problem hiding this comment.
double check if I really need this function
ktuite
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #741
What has been done to verify that this works as intended?
Integration tests and manual verification
Why is this the best possible solution? Were any other approaches considered?
Used the same approach as Submissions List
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
NA
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes