Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bootstrap CSS related to pagination #943

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

matthew-white
Copy link
Member

This PR removes the Bootstrap pagination and pager classes. We don't use those classes, and we're about to add a very different pagination component as part of getodk/central#589. I'd like to continue to find ways to trim the Bootstrap CSS that we ship with Central, as it's one of our largest assets.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@matthew-white matthew-white requested a review from ktuite February 23, 2024 19:26
@matthew-white matthew-white merged commit eef2012 into master Feb 23, 2024
1 check passed
@matthew-white matthew-white deleted the remove-bootstrap-pagination branch February 23, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants