Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a better error message when nginx returns 413 error #977

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Apr 23, 2024

Closes getodk/central#610

Screenshot 2024-04-23 at 4 24 18 PM

What has been done to verify that this works as intended?

I artificially lowered the nginx error to 1mb to trigger this.

Why is this the best possible solution? Were any other approaches considered?

I didn't see any filled in content-length info that I could have used to show the actual size in the error message. Also left the message pretty generic.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to user documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@ktuite ktuite requested a review from matthew-white April 23, 2024 23:26
@ktuite ktuite merged commit 54ec992 into master Apr 24, 2024
1 check passed
@ktuite ktuite deleted the ktuite/413_limit branch April 24, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show better error message for 413 from nginx
2 participants