Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enketo can now load config at runtime, so rebuilding is not needed #263

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Enketo can now load config at runtime, so rebuilding is not needed #263

merged 1 commit into from
Feb 9, 2022

Conversation

yanokwa
Copy link
Member

@yanokwa yanokwa commented Feb 3, 2022

Thanks to enketo/enketo#1133, Enketo can load its config at run time, so we no longer need to run npm and grunt.

I verified this change works by:

  1. Starting from a fresh install from this PR and confirming that form previews and public access links work.
  2. Starting from a fresh Central v1.3.3 install, applying this PR, and confirming that old and new form previews and public access links work.

@yanokwa yanokwa requested a review from issa-tseng February 3, 2022 01:23
@matthew-white matthew-white changed the base branch from master to release February 9, 2022 20:38
@matthew-white matthew-white merged commit f1a5c2e into getodk:release Feb 9, 2022
@matthew-white matthew-white mentioned this pull request Feb 9, 2022
Merged
@yanokwa yanokwa deleted the no-enketo-building branch May 31, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@issa-tseng issa-tseng issa-tseng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanokwa @issa-tseng @matthew-white