Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from nashmi/smtp to the more maintained ixdotai/smtp #392

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

yanokwa
Copy link
Member

@yanokwa yanokwa commented Feb 24, 2023

This PR introduces the maintained, drop-in replacement for namshi/smtp. namshi/docker-smtp#81 (comment)

I tested this by starting with a v2023.1.0 install, changing to this container, rebuilding, and sending a password reset email through an AWS SMTP server. I've also tested sending a password reset email through the server itself.

The reason for ignoreTLS is that exim now generates a self-signed cert and advertises itself as a TLS-enabled server. nodemailer, the Central library that sends the emails, doesn't like self-signed certs, so that's why there is a few flag.

Alternatives I rejected:

I did not test a DKIM setup, but we were on exim 4.92 and we are now on exim 4.97. I don't expect any breaking changes and https://github.com/Exim/exim/blob/master/doc/doc-txt/ChangeLog doesn't suggest that there are. Also, I doubt a lot of people use the DKIM option.

@yanokwa yanokwa changed the title Upgrade to updated fork Upgrade to updated fork of nashmi/smtp Feb 24, 2023
@yanokwa yanokwa marked this pull request as ready for review February 24, 2023 16:56
@yanokwa yanokwa changed the title Upgrade to updated fork of nashmi/smtp Change from nashmi/smtp to the more maintained ixdotai/smtp Feb 24, 2023
@matthew-white matthew-white changed the base branch from master to next February 24, 2023 18:03
@yanokwa yanokwa force-pushed the update-smtp branch 3 times, most recently from 44ea191 to e201c57 Compare February 25, 2023 00:34
Copy link
Member

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring TLS seems reasonable to me given the options. I do think we want to be on a supported image.

@lognaturel
Copy link
Member

Merging now so we can build on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ done
Development

Successfully merging this pull request may close these issues.

2 participants