Change from nashmi/smtp to the more maintained ixdotai/smtp #392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the maintained, drop-in replacement for namshi/smtp. namshi/docker-smtp#81 (comment)
I tested this by starting with a v2023.1.0 install, changing to this container, rebuilding, and sending a password reset email through an AWS SMTP server. I've also tested sending a password reset email through the server itself.
The reason for
ignoreTLS
is that exim now generates a self-signed cert and advertises itself as a TLS-enabled server. nodemailer, the Central library that sends the emails, doesn't like self-signed certs, so that's why there is a few flag.Alternatives I rejected:
MAIN_TLS_ENABLE = false
to _docker_additional_macros fails because TLS support is compiled in. https://www.exim.org/exim-html-current/doc/html/spec_html/ch-main_configuration.html suggests there is no way to turn it off.I did not test a DKIM setup, but we were on exim 4.92 and we are now on exim 4.97. I don't expect any breaking changes and https://github.com/Exim/exim/blob/master/doc/doc-txt/ChangeLog doesn't suggest that there are. Also, I doubt a lot of people use the DKIM option.