Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #416
What has been done to verify that this works as intended?
Did a
docker compose build
docker compose up -d
docker compose stop
after each commit to make sure each was minimal and effective. It's still on there if someone wants to do a sanity check.Why is this the best possible solution? Were any other approaches considered?
The underlying issue is that signals weren't being proxied to the intended processes. More at https://stackoverflow.com/a/32261019/137744. This was addressed by running all the various processes with
exec
.Additionally, the Enketo dockerfile needed to be updated to use the JSON-array syntax so it wouldn't be called with
/bin/sh -c
which is immune to SIGTERMHow does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This is an ops change. Worst case would be things don't stop or come up. I think if it works on dev it's likely to work anywhere.
I'm not entirely sure about risk beyond things not stopping or coming up.
I keep seeing things about the PID 1 zombie reaping problem but I can't tell if this changes anything with respect to that. This post suggests that it doesn't change anything.Thistini
post has more about zombie processes. Given my understanding of the processes we launch, I believe it's unlikely that any secondary processes likely to become zombies are being launched.Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have: