-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #428
Update dependencies #428
Conversation
If we wanted additional verification of this change, we could update Node in central-backend and central-frontend. These look to be the PRs from the last update: getodk/central-backend#786, getodk/central-frontend#746. The main benefit of that would be getting to run Backend and Frontend tests in CircleCI under the new version of Node. But also regression testing would probably catch most issues. |
@@ -1,4 +1,4 @@ | |||
FROM postgres:14 | |||
FROM postgres:14.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize this at first, but some users will have 14.7 or maybe even 14.6 installed, so this will be an upgrade for them. (I initially thought that this line was just pinning the current version.) I don't see why this change would be an issue, but I thought I'd make a note of it. Nothing special needs to happen when upgrading within a major version of Postgres, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test.central.getodk.org is at Postgres 14.6, so we'll get a test of 14.6→14.8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing special needs to happen when upgrading within a major version of Postgres, right
It shouldn't be the case but mistakes happen so that's why the pinning seems like a good idea moving forward.
Closes #398
I have standardized on pinning the major and minor versions for standard Docker images. This feels like the right balance between predictability and getting updates.
What has been done to verify that this works as intended?
It's on the dev server.
Why is this the best possible solution? Were any other approaches considered?
I also considered pinning the patch version or a SHA to ensure consistency. But i think this is a good balance.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The only minor version changed is for node. I haven't looked at the release notes.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have: