fixes #438 #443
Merged
fixes #438 #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncodes path which breaks submission attachment with special characters in webform more details: https://trac.nginx.org/nginx/ticket/2506
|
Targeting the |
There was a problem hiding this comment.
This seems like a reasonable approach for now, and I can't think of any downsides. This approach causes nginx to behave how we already thought it was. It's also more similar to how we use proxy_pass for Backend.
We've discussed how Enketo has unexpected requirements related to URL encoding. However, we're not sure yet how big changing that in Enketo would be. I'd be glad for us to continue that discussion, but I think this is a nice change for now.
matthew-white
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #438: if URI is given in proxy_pass then nginx decodes and re-encodes path
which breaks submission attachment with special characters in webform more details: https://trac.nginx.org/nginx/ticket/2506
What has been done to verify that this works as intended?
Manually verified it locally and on Dev server
Why is this the best possible solution? Were any other approaches considered?
This is simplest and safest fix. I am going to create separate issue to investigate encoding protocol between Central and Enketo.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
None
Does this change require updates to documentation? If so, please file an issue here and include the link below.
None
Before submitting this PR, please make sure you have: