Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress towards #440 Closes #441
What has been done to verify that this works as intended?
pyxform
: converted a form withlist_name
onentities
sheet to verify the latest version is usedpostgres
: clicked around on dev serverredis
: opened a few forms on dev server@yanokwa will submit a separate PR for this update.smtp
: this one was the most annoying. There's nothing particularly significant in the changelog but I still wanted to verify it. In this process, I discovered that Digital Ocean now blocks SMTP. I pulled @yanokwa in. We verified exim logs inside the container to make sure messages were being queued in the same way as with prior versions. He also verified that https://www.mail-tester.com/ gets email delivered. In doing all this he discovered some DKIM-related bugs that he'll follow up on.Why is this the best possible solution? Were any other approaches considered?
I checked all docker files and docker-compose for versions to update. I believe this is exhaustive.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I don't see much risk after the verification above.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have: