Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't HTML-encode formid or version #4554

Closed
lognaturel opened this issue May 10, 2021 · 2 comments · Fixed by getodk/javarosa#685 or #5155
Closed

Don't HTML-encode formid or version #4554

lognaturel opened this issue May 10, 2021 · 2 comments · Fixed by getodk/javarosa#685 or #5155
Labels
Milestone

Comments

@lognaturel
Copy link
Member

lognaturel commented May 10, 2021

Collect HTML-encodes all unicode for reasons I am unsure of. This is generally ok but it's problematic for formid and version because servers expect an exact match. At the very least, we should pass through formid and version unchanged. There might be a broader question about whether it makes sense to HTML-encode anything but perhaps that's best left for another time if we can find a reasonable way to fix just the formid and version identifiers.

Enketo correctly passes through any unicode in formid or version.

tést.xlsx

@lognaturel lognaturel added bug help wanted Issues that are well-specified and don't require too much context. and removed help wanted Issues that are well-specified and don't require too much context. labels May 10, 2021
@lognaturel lognaturel added this to the v2022.3 milestone Apr 12, 2022
@lognaturel
Copy link
Member Author

lognaturel commented Apr 12, 2022

Users have been running into this with some frequency. Let's at least see what our options are here.

  • is the whole submission blob HTML-encoded?

@lognaturel
Copy link
Member Author

lognaturel commented May 31, 2022

We've decided to move forward with building true UTF-8 submissions (matching Enketo). The JR change has gone in (thanks, @seadowg!). We need to incorporate it here and also add the encoding attribute.

@seadowg seadowg mentioned this issue Jun 1, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant