Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4554
This upgrades JavaRosa so that instance files are now encoded as UTF-8 (rather than ASCII with escaped characters). Unicode will now be unescaped in instance XML and there is an
encoding
attribute added to the XML doc itself.What has been done to verify that this works as intended?
Ran existing tests and verified that forms now included unicode manually (there are tests on the JavaRosa side for this).
Why is this the best possible solution? Were any other approaches considered?
Discussion at getodk/javarosa#685.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It would be good to do a general pass on saving/submitting forms with emoji or other unicode.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.