Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JavaRosa #5155

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Upgrade JavaRosa #5155

merged 1 commit into from
Jun 13, 2022

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jun 1, 2022

Closes #4554

This upgrades JavaRosa so that instance files are now encoded as UTF-8 (rather than ASCII with escaped characters). Unicode will now be unescaped in instance XML and there is an encoding attribute added to the XML doc itself.

What has been done to verify that this works as intended?

Ran existing tests and verified that forms now included unicode manually (there are tests on the JavaRosa side for this).

Why is this the best possible solution? Were any other approaches considered?

Discussion at getodk/javarosa#685.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It would be good to do a general pass on saving/submitting forms with emoji or other unicode.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review June 1, 2022 13:58
@seadowg seadowg requested a review from lognaturel June 1, 2022 13:58
@srujner
Copy link

srujner commented Jun 8, 2022

Tested with Success!
Verified on Androids: 10, 11 and 12

Verified Cases:

  • Saving Forms;
  • Sending finalized Forms to the Central;
  • Editing saved Forms;
  • Regression check on forms with Text widgets, sending emojis and other Unicode symbols;
  • Hierarchy view

@seadowg
Copy link
Member Author

seadowg commented Jun 13, 2022

@srujner should this be behavior verified now?

@srujner
Copy link

srujner commented Jun 13, 2022

@seadowg We are only waiting for @kkrawczyk123 to check this also on Android 5.1

@kkrawczyk123
Copy link
Contributor

Tested also on Androids 5.1 and 8.1.

@seadowg seadowg merged commit d9c8b84 into getodk:master Jun 13, 2022
@seadowg seadowg deleted the utf-encoding branch June 13, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't HTML-encode formid or version
4 participants