Fix property eq expressions for entities

[seadowg]

Closes #6304
Closes #6314
Blocked by #6318

Why is this the best possible solution? Were any other approaches considered?

There's two key fixes here:

1. Making sure new properties are added to existing local entities (like they would be in the CSV)
2. Making sure that thing = '' expressions behave as they would in JavaRosa when they end up going through getAllByProperty

It's interestingly up for debate whether the behaviour for 2 is correct or not though in the case where thing is not a node that exists on the filtered nodes: JavaRosa would return all nodes, whereas Enketo would return none. It's likely that Enketo's behaviour is more correct here, but after discussing with @lognaturel we've decided to keep entities and JavaRosa evaluation consistent and then make all the ODK tools consistent later once web forms is dealing with secondary instances.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Firstly, because this PR makes changes to the entities DB but doesn't perform any migrations (as we haven't released the DB yet), the app should be uninstalled/reinstalled or data should be cleared before testing this.

Other than that, checking the bug is fixed and that entity forms (especially those with filtered selects) behave as expected is the most important thing.

Before submitting this PR, please make sure you have:

• added or modified tests for any new or changed behavior
• run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
• added a comment above any new strings describing it for translators
• added any new strings with date formatting to DateFormatsTest
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[seadowg]

@dbemke could you check for me if this also fixes #6336?

[dbemke]

#6336 crashes the app

[grzesiek2010]

Can properties have blank values like " "? Is it sanitized somewhere? I'm wondering if here we should use value.isBlank() instead.

[seadowg]

This case only occurs if the property doesn't actually exist for the entities. It's the special case described above:

It's interestingly up for debate whether the behaviour for 2 is correct or not though in the case where thing is not a node that exists on the filtered nodes: JavaRosa would return all nodes, whereas Enketo would return none.

[grzesiek2010]

This case only occurs if the property doesn't actually exist for the entities.

I see but isn't it somehow possible that it doesn't exist and the value here is not "" but " "?

[seadowg]

I see but isn't it somehow possible that it doesn't exist and the value here is not "" but " "?

Yes, but in that case we'd return an empty list because we'd be searching for nodes with a non-existent property equal to "something" rather than "nothing" and JavaRosa treats non-existent nodes as having the value "". Basically thing = ' ' is the same as thing = 'blah' if thing doesn't exist.

[WKobus]

Tested with Success

Verified on device with Android 14

Verified cases:

• Issue Empty select in the card distribution form after sending registration form (offline entities enabled) #6304 does not occur
• Entity forms with filtered selects
• Offline entities
• Regression check on entities

[dbemke]

Tested with Success

Verified on device with Android 10