Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not proceed with LocalEntitiesFilterStrategy filtering if instanceId is null #6412

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Sep 12, 2024

Closes #6378

Why is this the best possible solution? Were any other approaches considered?

We should check if instanceId is null and only if it is not should we proceed with LocalEntitiesFilterStrategy. When it comes to performing filtering on repeats it will be null and of course in this case LocalEntitiesFilterStrategy should not be used.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It's a pretty safe change so testing the scenario described in the issue should be enough.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 changed the title Do not proceed filtering with LocalEntitiesFilterStrategy if instanceId is null Do not proceed with LocalEntitiesFilterStrategy filtering if instanceId is null Sep 13, 2024
@grzesiek2010 grzesiek2010 marked this pull request as ready for review September 13, 2024 10:18
@grzesiek2010 grzesiek2010 merged commit 60c200b into getodk:master Sep 13, 2024
6 checks passed
@dbemke
Copy link

dbemke commented Sep 16, 2024

Tested with Success!

Verified on a device with Android 10

Verified Cases:

@WKobus
Copy link

WKobus commented Sep 16, 2024

Tested with Success

Verified on device with Android 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter expression on a repeat crashes attempting to check applicability of Entities filter strategy
4 participants