Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the filtering of duplicate columns #6538

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Nov 29, 2024

Closes #6537

Why is this the best possible solution? Were any other approaches considered?

Filtering out duplicate columns that we recently introduced worked well the first time, when no columns had been generated from properties. However, during subsequent saves, the comparison with already existing columns didn't work as expected.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This pull request should resolve the issue. I don't see any risks that need to be highlighted.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 requested a review from seadowg November 29, 2024 18:24
@seadowg seadowg merged commit 069a192 into getodk:master Dec 3, 2024
6 checks passed
@seadowg seadowg added the high priority Should be looked at before other PRs/issues label Dec 5, 2024
seadowg added a commit to seadowg/collect that referenced this pull request Dec 5, 2024
Fixed the filtering of duplicate columns
@seadowg seadowg mentioned this pull request Dec 5, 2024
6 tasks
@WKobus
Copy link

WKobus commented Dec 6, 2024

@grzesiek2010 We currently hold on testing this, as issue that is fixed by this PR still occurs on newest master version b0fd74c

@seadowg
Copy link
Member

seadowg commented Dec 9, 2024

@getodk/testers removing "needs testing" from this as #6543 replaces it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Should be looked at before other PRs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash of the app after sending twice registration form that creates p_ and P_ entity property
3 participants