Switch to gunicorn and use older binaries #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hon to reduce space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19.
The switch to Gunicorn is purely because it supports max-requests (killing a worker after finishing) so we don't have to deal with the leaks in pyxform/Validate. Related: getodk/xlsform-server#22.
waitress defaults to 4 workers. Here we default to 5 based on the 2*CPUs+1 recommendation. max-requests is 1 because we really want to make sure to solve the memory leak. We add some jitter to all workers from restarting at once.
Timeout is increased to 600. We've done that on xlsform-online and it seems to work OK.
The switch to OpenJDK 1.8 is because it's smaller than OpenJDK 11. That's an assumption, I haven't actually checked. 1.8 is the minimum that JavaROSA supports.
The same "older versions are smaller" is why I've reverted to Python 3.6. It gets deprecated at the end of 2021, but it's fine for now.