Skip to content

Commit

Permalink
fix: upgrade @getoutreach/eslint-config to 2.0.0 (#497)
Browse files Browse the repository at this point in the history
  • Loading branch information
malept committed May 6, 2024
1 parent 50ed31e commit 981709f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 33 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,8 @@ updates:
- dependency-name: "@typescript-eslint/eslint-plugin"
- dependency-name: "@typescript-eslint/parser"
- dependency-name: "eslint"
- dependency-name: "eslint-config-prettier"
- dependency-name: "eslint-plugin-jest"
- dependency-name: "eslint-plugin-jsdoc"
- dependency-name: "eslint-plugin-lodash"
- dependency-name: "eslint-plugin-node"
- dependency-name: "grpc-tools"
- dependency-name: "grpc_tools_node_protoc_ts"
Expand Down
18 changes: 7 additions & 11 deletions templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -175,23 +175,19 @@ nodejs:
{{- end }}
devDependencies:
- name: "@getoutreach/eslint-config"
version: ^1.0.4
version: ^2.0.0
- name: "@types/jest"
version: ^26.0.15
- name: "@typescript-eslint/eslint-plugin"
version: ^2.33.0
version: ^7.8.0
- name: "@typescript-eslint/parser"
version: ^2.33.0
version: ^7.8.0
- name: eslint
version: ^7.13.0
- name: eslint-config-prettier
version: ^6.15.0
version: ^8.57.0
- name: eslint-plugin-jest
version: ^24.1.3
version: ^28.3.0
- name: eslint-plugin-jsdoc
version: ^30.7.7
- name: eslint-plugin-lodash
version: ^7.1.0
version: ^48.2.3
- name: eslint-plugin-node
version: ^11.1.0
- name: grpc-tools
Expand All @@ -213,7 +209,7 @@ nodejs:
- name: tsconfig-paths
version: ^3.9.0
- name: typescript
version: ^4.0.5
version: ^4.9.5
{{- range stencil.GetModuleHook "js_modules_dev" }}
- name: {{ .name }}
version: {{ .version }}
Expand Down
21 changes: 1 addition & 20 deletions templates/api/clients/node/.eslintrc.js.tpl
Original file line number Diff line number Diff line change
@@ -1,23 +1,4 @@
{{- $_ := stencil.ApplyTemplate "skipGrpcClient" "node" }}
module.exports = {
extends: ['@getoutreach/eslint-config/node', 'plugin:jsdoc/recommended'],
plugins: ['jsdoc', '@typescript-eslint'],
ignorePatterns: ['*.d.ts', 'publish.js'],
rules: {
'node/no-unsupported-features/es-syntax': 'off', // Typescript syntax uses unsupported features in node v10
'node/no-missing-import': 'off', // The import detection doesn't seem to work with TS and node v10
// JSDoc rules
// The param type is redundant with the typescript specified type so is disabled
'jsdoc/require-param-type': 0,
'jsdoc/require-returns-type': 0
},
parser: '@typescript-eslint/parser',
parserOptions: {
ecmaVersion: 6,
sourceType: 'module',
ecmaFeatures: {
modules: true
}
}
extends: ['@getoutreach/eslint-config/node'],
};

0 comments on commit 981709f

Please sign in to comment.