Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vscode/additional-extensions module hook #452

Merged
merged 8 commits into from
May 1, 2024

Conversation

Ned-el-ch
Copy link
Contributor

@Ned-el-ch Ned-el-ch commented Mar 15, 2024

Please read CONTRIBUTING.md for additional information on contributing to this repository!

What this PR does / why we need it

Adds a hook call for .vscode/extensions.json inside the recommended extensions to allow for any custom extensions to be added via hooks

Jira ID

DT-4211

Notes for your reviewers

@Ned-el-ch Ned-el-ch requested a review from a team as a code owner March 15, 2024 12:36
Copy link

swarmia bot commented Mar 15, 2024

@Ned-el-ch Ned-el-ch force-pushed the feat/use-the-additonal-extensions-hook branch from c626e41 to dc3b058 Compare March 18, 2024 09:53
@Ned-el-ch Ned-el-ch changed the title feat: use teh .vscode/extensions hook from stencil-outreach feat: add wizcli to extensions Mar 18, 2024
templates/.vscode/extensions.json.tpl Outdated Show resolved Hide resolved
@malept
Copy link
Member

malept commented Mar 18, 2024

The new module hook also needs to be added to the docs: https://github.com/getoutreach/stencil-golang/blob/main/docs/module-hooks.md

@Ned-el-ch Ned-el-ch changed the title feat: add wizcli to extensions feat: add .vscode/extensions module hook Mar 19, 2024
docs/module-hooks.md Outdated Show resolved Hide resolved
templates/.vscode/extensions.json.tpl Outdated Show resolved Hide resolved
docs/module-hooks.md Outdated Show resolved Hide resolved
docs/module-hooks.md Outdated Show resolved Hide resolved
docs/module-hooks.md Outdated Show resolved Hide resolved
@malept malept changed the title feat: add .vscode/extensions module hook feat: add vscode/additional-extensions module hook Apr 24, 2024
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it out, seems to work fine.

@malept malept merged commit 099535d into main May 1, 2024
2 checks passed
@malept malept deleted the feat/use-the-additonal-extensions-hook branch May 1, 2024 18:37
@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.23.0-rc.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants