fix: stop forwarding dlv port when skipped #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
reviewed
Mar 27, 2024
| @@ -365,11 +365,6 @@ profiles: | |||
| activation: | |||
| - vars: | |||
| DEVENV_DEV_SKIP_PORTFORWARDING: "true" | |||
There was a problem hiding this comment.
question: do we need to get rid of lines 363-367 too?
There was a problem hiding this comment.
No, we still need the skipPortForwarding devspace profile, which will be triggered by the env : DEVENV_DEV_SKIP_PORTFORWARDING: "true"
malept
approved these changes
Mar 27, 2024
|
🎉 This PR is included in version 1.22.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
Fix the bug when
--skip-portforwardingapplied, dlv port is still forwarded.Jira ID
DT-4305
Notes for your reviewers