Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop forwarding dlv port when skipped #458

Merged
merged 2 commits into from
Mar 27, 2024
Merged

fix: stop forwarding dlv port when skipped #458

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16a4f74
fix: do not forward dlv port for skip-portforwarding
yj-yan Mar 27, 2024
91dd0bc
update snapshot
yj-yan Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions templates/devspace.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,11 +365,6 @@ profiles:
activation:
- vars:
DEVENV_DEV_SKIP_PORTFORWARDING: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do we need to get rid of lines 363-367 too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we still need the skipPortForwarding devspace profile, which will be triggered by the env : DEVENV_DEV_SKIP_PORTFORWARDING: "true"

patches:
- op: replace
path: dev.app.ports
value:
- port: ${DLV_PORT}

- name: e2eBase
description: Basic configuration override for all e2e test profiles
Expand Down