fix: upgrade controller-gen to 0.14.0 to fix panic #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
requested changes
Mar 27, 2024
|
Do we need to be concerned about breaking changes since it's a minor bump but pre-1.0? |
controller-gen panics on some of our repos now, specifically found this
in database-credential-operator.
```
go run sigs.k8s.io/controller-tools/cmd/controller-gen@v0.7.0 object paths=./api/k8s/database/v1
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x103280e80]
```
kubernetes-sigs/controller-tools#888
evadnoob
force-pushed
the
evadnoob/fix/controll-gen-version-upgrade-to-0.14.0
branch
from
f88ea1c
to
8c9dc22
Compare
I'll test unstable |
evadnoob
deleted the
evadnoob/fix/controll-gen-version-upgrade-to-0.14.0
branch
|
🎉 This PR is included in version 1.22.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controller-gen panics on some of our repos now, specifically found this in database-credential-operator.
kubernetes-sigs/controller-tools#888