fix(golangci-lint): remove obsolete timeCmpSimplify exclusion #491
+0
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Story DT-4298 · Update golangci-lint to 1.57.2 |
malept
requested changes
Apr 22, 2024
There was a problem hiding this comment.
The change itself looks fine, but I'm holding off on merging it until getoutreach/devbase#776 is merged.
malept
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
Removes
timeCmpSimplifyas it's been deprecated in go-critic.Jira ID
DT-4298
Notes for your reviewers