Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ruby client.gemspec spaces #539

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

honzap
Copy link
Contributor

@honzap honzap commented Sep 12, 2024

Please read CONTRIBUTING.md for additional information on contributing to this repository!

What this PR does / why we need it

When file.Block is empty, the spaces are left there. IDEs +make fmt are then trying to delete those spaces which creates a change differing from the stencil template. This small fix corrects that.

Jira ID

[XX-XX]

Notes for your reviewers

@honzap honzap requested a review from a team as a code owner September 12, 2024 16:43
Copy link
Contributor

@romain-tadiello romain-tadiello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 🙏

@honzap honzap enabled auto-merge (squash) September 12, 2024 19:10
@honzap honzap merged commit 6b1b317 into main Sep 12, 2024
2 checks passed
@honzap honzap deleted the honzap/chore/rubygemspecspaces branch September 12, 2024 19:14
@getoutreach-ci-1
Copy link
Contributor

🎉 This issue has been resolved in version 1.24.1-rc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants