Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pelican_comment_system] Logs a warning if the parent of a comment can not be found. #715

Merged
merged 1 commit into from
May 22, 2016
Merged

[pelican_comment_system] Logs a warning if the parent of a comment can not be found. #715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pelican_comment_system/pelican_comment_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,16 @@ def add_static_comments(gen, content):

# TODO: Fix this O(n²) loop
for reply in replies:
found_parent = False
for comment in chain(comments, replies):
if comment.slug == reply.replyto:
comment.addReply(reply)
found_parent = True
break
if not found_parent:
logger.warning('Comment "%s/%s" is a reply to non-existent comment "%s". '
'Make sure the replyto attribute is set correctly.',
content.slug, reply.slug, reply.replyto)

count = 0
for comment in comments:
Expand Down